Skip to content

Docs: Safelisting with PQ moving content#8853

Merged
mabuyo merged 3 commits intodevfrom
DXM-108
Feb 3, 2026
Merged

Docs: Safelisting with PQ moving content#8853
mabuyo merged 3 commits intodevfrom
DXM-108

Conversation

@mabuyo
Copy link
Copy Markdown
Contributor

@mabuyo mabuyo commented Feb 2, 2026

We've received feedback in the past that having 2 separate pages with the same title "Safelisting with persisted queries" located in different docs sections containing overlapping content has been confusing.

Our solution is to keep just one canonical source of information (in the GraphOS Platform docs) and have the other one (Router docs) point to it.

We have a separate docs PR here that moves all the router configuration and other unique content over to the GraphOS Platform docs.

This particular PR (to be merged after the other one) removes all the duplicated information, provides a small description to introduce the reader to the feature, then redirects them to the other docs page. Also fixes a few links where it makes sense.


Checklist

Complete the checklist (and note appropriate exceptions) before the PR is marked ready-for-review.

  • PR description explains the motivation for the change and relevant context for reviewing
  • PR description links appropriate GitHub/Jira tickets (creating when necessary)
  • Changeset is included for user-facing changes
  • Changes are compatible1
  • Documentation2 completed
  • Performance impact assessed and acceptable
  • Metrics and logs are added3 and documented
  • Tests added and passing4
    • Unit tests
    • Integration tests
    • Manual tests, as necessary

Exceptions

Note any exceptions here

Notes

Footnotes

  1. It may be appropriate to bring upcoming changes to the attention of other (impacted) groups. Please endeavour to do this before seeking PR approval. The mechanism for doing this will vary considerably, so use your judgement as to how and when to do this.

  2. Configuration is an important part of many changes. Where applicable please try to document configuration examples.

  3. A lot of (if not most) features benefit from built-in observability and debug-level logs. Please read this guidance on metrics best-practices.

  4. Tick whichever testing boxes are applicable. If you are adding Manual Tests, please document the manual testing (extensively) in the Exceptions.

@apollo-librarian
Copy link
Copy Markdown
Contributor

apollo-librarian bot commented Feb 2, 2026

✅ Docs preview ready

The preview is ready to be viewed. View the preview

File Changes

0 new, 4 changed, 0 removed
* graphos/routing/(latest)/configuration/yaml.mdx
* graphos/routing/(latest)/query-planning/caching.mdx
* graphos/routing/(latest)/security/index.mdx
* graphos/routing/(latest)/security/persisted-queries.mdx

Build ID: 68cfc35bd64ef31e3b714922
Build Logs: View logs

URL: https://www.apollographql.com/docs/deploy-preview/68cfc35bd64ef31e3b714922

@mabuyo mabuyo marked this pull request as ready for review February 3, 2026 16:00
@mabuyo mabuyo requested a review from a team as a code owner February 3, 2026 16:00
Copy link
Copy Markdown
Contributor Author

@mabuyo mabuyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AI review comments

Comment thread docs/source/routing/security/persisted-queries.mdx Outdated
Comment thread docs/source/routing/security/persisted-queries.mdx Outdated
Comment thread docs/source/routing/security/index.mdx Outdated
Comment thread docs/source/routing/query-planning/caching.mdx Outdated
Comment thread docs/source/routing/configuration/yaml.mdx Outdated
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2026

@mabuyo, please consider creating a changeset entry in /.changesets/. These instructions describe the process and tooling.

Copy link
Copy Markdown
Contributor

@the-gigi-apollo the-gigi-apollo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The actual content is LGTM. The dependent PR that moves the pages was merged already, so this is unblocked.

There is a failing circleci auto-compliance check, no changeset and a few AI comments.

@mabuyo mabuyo merged commit a7ddd7c into dev Feb 3, 2026
14 of 15 checks passed
@mabuyo mabuyo deleted the DXM-108 branch February 3, 2026 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants